Draft
Conversation
Make it a scoped service so only 1 MongoClient is created per request Use that to expose transactions which are now shared across all Repos
…ev/TheCombine into expose-mongo-transactions
Collaborator
Author
|
Possibly revisit this after Q1 next year. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3484 +/- ##
==========================================
- Coverage 74.65% 66.67% -7.98%
==========================================
Files 285 234 -51
Lines 10999 5821 -5178
Branches 1338 706 -632
==========================================
- Hits 8211 3881 -4330
+ Misses 2404 1715 -689
+ Partials 384 225 -159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
12 tasks
Collaborator
Author
|
Waiting on #4183 to be resolved |
github-actions
bot
added
test
goal: MergeDup
component: TreeView
audio
project
login/signUp
goal
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for combining multiple changes into an atomic, all-or-nothing change. It would be useful for:
However, to do this, we first have to convert our mongo setup from standalone to a replica set: https://www.mongodb.com/docs/manual/tutorial/convert-standalone-to-replica-set/
This change is